They do the job by trapping drinking water inside the curve and blocking the fuel from returning to your home. If your smell arises from a sink, operate the water to get a handful of seconds to revive the trap. In case the smell comes from a floor drain for instance a shower drain, pour a pitcher of h2o down the drain to restore the proper function